test(web): pin charter-#3 crossing-banner de-allowlist in regression KAT (SAFE-ADDITIVE) - #522
Merged
frstrtr merged 1 commit intoJun 26, 2026
Conversation
…KAT (SAFE-ADDITIVE) #496 replaced the hardcoded {LITECOIN,DOGECOIN} version_signaling allowlist with a single DASH (static v16) exclusion so the V35->V36 crossing banner surfaces on every v36-ratcheting coin. Pin that behaviour: - BTC + DGB (coins the old allowlist would have suppressed) surface the live crossing state and vote tally from the sharechain stats hook. - DASH stays suppressed (empty) even with full vote data wired -- no real V35->V36 transition exists on a static-v16 chain. - a ratcheting coin with <10 shares returns empty until there is real crossing state, never a misleading transition. Test-only, additive: 13 -> 17 cases, full suite green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the web honesty-regression KAT to cover #496 (version_signaling crossing-banner de-allowlist).
Before #496 a hardcoded {LITECOIN,DOGECOIN} allowlist gated rest_version_signaling(), so a BTC/DGB/BCH node mid-cross showed NO V35->V36 crossing banner — the dashboard hid the very state the operator most needs to see during the upgrade. #496 replaced the allowlist with a single DASH (static v16, non-ratcheting) exclusion. These pins lock that in:
Test-only, SAFE-ADDITIVE: honesty KAT 13 -> 17 cases, full suite green locally. Non-consensus web layer.